The following document contains the results of FindBugs Report
FindBugs Version is 1.3.2
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 117 | 17 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.restafarian.example.beans.LeaveRequest.getDateTimeEntered() may expose internal representation by returning LeaveRequest.dateTimeEntered | MALICIOUS_CODE | EI_EXPOSE_REP | 28 | Medium |
| org.restafarian.example.beans.LeaveRequest.getDateTimeResolved() may expose internal representation by returning LeaveRequest.dateTimeResolved | MALICIOUS_CODE | EI_EXPOSE_REP | 34 | Medium |
| org.restafarian.example.beans.LeaveRequest.setDateTimeEntered(Date) may expose internal representation by storing an externally mutable object into LeaveRequest.dateTimeEntered | MALICIOUS_CODE | EI_EXPOSE_REP2 | 31 | Medium |
| org.restafarian.example.beans.LeaveRequest.setDateTimeResolved(Date) may expose internal representation by storing an externally mutable object into LeaveRequest.dateTimeResolved | MALICIOUS_CODE | EI_EXPOSE_REP2 | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in org.restafarian.example.servlets.CountrySelectorServlet.capitalize(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 197 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 150 | Low |
| Class org.restafarian.example.servlets.CountrySelectorServlet.allOptions extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 64 | Low |
| Class org.restafarian.example.servlets.CountrySelectorServlet.allOptions extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 125 | Low |
| Class org.restafarian.example.servlets.CountrySelectorServlet.expirationDate extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 126 | Low |
| org.restafarian.example.servlets.CountrySelectorServlet.loadOptions() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 113 | Medium |
| Exception is caught when Exception is not thrown in org.restafarian.example.servlets.CountrySelectorServlet.loadOptions() | STYLE | REC_CATCH_EXCEPTION | 122 | Low |
| Class org.restafarian.example.servlets.CountrySelectorServlet defines non-transient non-serializable instance field log | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.restafarian.example.servlets.LeaveRequestEntryServlet defines non-transient non-serializable instance field log | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() comparing different types in org.restafarian.example.servlets.LeaveRequestServlet.sendLeaveRequest(int, HttpServletRequest, HttpServletResponse) | CORRECTNESS | EC_UNRELATED_TYPES | 132 | High |
| Call to equals() comparing different types in org.restafarian.example.servlets.LeaveRequestServlet.updateLeaveRequest(int, HttpServletRequest, HttpServletResponse) | CORRECTNESS | EC_UNRELATED_TYPES | 170 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.restafarian.example.utils.ConfigFactory.getConfiguration() needlessly instantiates a class that only supplies static methods | BAD_PRACTICE | ISC_INSTANTIATE_STATIC_CLASS | 35 | Low |
| Incorrect lazy initialization of static field org.restafarian.example.utils.ConfigFactory.factory in org.restafarian.example.utils.ConfigFactory.getConfiguration() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 34-35 | Low |
