The following document contains the results of FindBugs Report
FindBugs Version is 1.3.8
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 90 | 8 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.restafarian.notify.beans.MessageAddress.getAddressValues() may expose internal representation by returning MessageAddress.addressValues | MALICIOUS_CODE | EI_EXPOSE_REP | 61 | Medium |
| org.restafarian.notify.beans.MessageAddress.setAddressValues(String[]) may expose internal representation by storing an externally mutable object into MessageAddress.addressValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.restafarian.notify.manager.impl.NoticeAuditManagerImpl.findById(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 57 | Medium |
| NoticeAuditManagerImpl.dao not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.restafarian.notify.manager.impl.NoticeTemplateManagerImpl.findById(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 57 | Medium |
| NoticeTemplateManagerImpl.dao not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| DeliveryServiceImpl.messageCourierFactory not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.restafarian.notify.service.impl.NotifierImpl.findHttpServletRequest(Object) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 223 | Medium |